Skip to content

Addresses bug where blank lines are dropped when there is no shebang#2328

Merged
cjames23 merged 3 commits into
pypa:masterfrom
cjames23:fix-flaky-test
Jun 28, 2026
Merged

Addresses bug where blank lines are dropped when there is no shebang#2328
cjames23 merged 3 commits into
pypa:masterfrom
cjames23:fix-flaky-test

Conversation

@cjames23

Copy link
Copy Markdown
Member

Fixes #2319

Track blank lines and only discard if we find a shebang

@henryiii henryiii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Comment thread backend/src/hatchling/builders/wheel.py
@cjames23 cjames23 merged commit e3d9b95 into pypa:master Jun 28, 2026
49 checks passed
@cjames23 cjames23 deleted the fix-flaky-test branch June 28, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test_default_shared_scripts: shared-scripts shebang rewriter drops leading blank line from random binary fixture

3 participants